Skip to content

Add radiation loss function plot - #4488

Merged
timothy-nunn merged 4 commits into
mainfrom
add_radiation_loss_function_plot
Aug 4, 2026
Merged

Add radiation loss function plot#4488
timothy-nunn merged 4 commits into
mainfrom
add_radiation_loss_function_plot

Conversation

@chris-ashe

@chris-ashe chris-ashe commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

This pull request refactors and extends the impurity radiation profile plotting functionality in process/core/io/plot/summary.py. The main changes include renaming and updating the radiation profile plotting function for clarity and consistency, adding a new function to plot the line and bremsstrahlung loss function profile, and updating the summary plotting page to use these new functions and improve subplot arrangement.

Plotting function improvements:

  • Renamed and refactored plot_radprofile to plot_line_bhrem_power_density_profile, updating its API to use a more descriptive name and clearer parameter types, and switching from the prof argument to axis for consistency with matplotlib conventions.
  • Added a new function plot_line_bhrem_loss_function_profile to plot the line and bremsstrahlung loss function ($L_z$) profiles, including log-log interpolation and improved axis labeling.
image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe
chris-ashe marked this pull request as ready for review July 29, 2026 15:51
@chris-ashe
chris-ashe requested a review from a team as a code owner July 29, 2026 15:51
@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.29885% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.21%. Comparing base (78d50cc) to head (caf4c7a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/plot/summary.py 2.29% 85 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4488      +/-   ##
==========================================
+ Coverage   48.73%   49.21%   +0.48%     
==========================================
  Files         151      151              
  Lines       29766    29667      -99     
==========================================
+ Hits        14505    14600      +95     
+ Misses      15261    15067     -194     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn
timothy-nunn requested a review from a team August 3, 2026 07:21
@timothy-nunn timothy-nunn self-assigned this Aug 3, 2026
@mkovari

mkovari commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

The plots look nice.
Please replace the string bhrem with brem in functions and variable names as this stands for "bremsstrahlung".

Comment thread documentation/source/physics-models/plasma_radiation.md Outdated
@chris-ashe
chris-ashe requested a review from ajpearcey August 4, 2026 08:57
@chris-ashe
chris-ashe force-pushed the add_radiation_loss_function_plot branch from 493af6b to caf4c7a Compare August 4, 2026 10:20
@timothy-nunn
timothy-nunn merged commit 2cdcf4b into main Aug 4, 2026
10 of 11 checks passed
@timothy-nunn
timothy-nunn deleted the add_radiation_loss_function_plot branch August 4, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants