Report completionDate as null and add --completed-since filter - #9
Merged
Merged
Conversation
Previously the completionDate key was omitted entirely for incomplete reminders instead of being emitted as null, making the field unreliable to consume from JSON output.
Lets callers scope completed reminders to a date range, e.g. answering "what got completed this week", by filtering on completionDate with an inclusive lower bound. Requires --only-completed or --include-completed, since there's nothing to filter otherwise.
udondan
added a commit
that referenced
this pull request
Sep 13, 2026
) * feat: always include completionDate in JSON output Previously the completionDate key was omitted entirely for incomplete reminders instead of being emitted as null, making the field unreliable to consume from JSON output. * feat: add --completed-since filter to show and show-all Lets callers scope completed reminders to a date range, e.g. answering "what got completed this week", by filtering on completionDate with an inclusive lower bound. Requires --only-completed or --include-completed, since there's nothing to filter otherwise.
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completionDatein JSON output, asnullfor incomplete reminders instead of omitting the key entirely.--completed-since <date>toshow/show-all, filtering completed reminders to those completed on or after a given date (inclusive lower bound, same natural-language date parsing as--due-date/--due-after). Requires--only-completedor--include-completed.Note on deleting completed reminders (upstream issue keith/reminders-cli#95 / PR #103): this is already resolved on
mainviae41ba9a, which letsdelete <list> <externalId>find a reminder regardless of completion state. PR #103 upstream is unmerged and solves it differently (via separate--id/--indexflags); nothing from it needed to be pulled in here.Test plan
swift build -Xswiftc -warnings-as-errorsswift test -Xswiftc -warnings-as-errors(89/89 passing, including newFilterTestscases for--completed-since)reminders show-all --completed-since mondaywithout--only-completed/--include-completedcorrectly errors--helpoutput shows the new--completed-sinceoption on bothshowandshow-all