chore: reset version manifest to 2.5.1 after deleting the broken v3.0.0 release - #24
Merged
Merged
Conversation
….0 release Deleting the v3.0.0 release/tag without also resetting these files left the manifest saying the previous version was already 3.0.0. release-please's bootstrap fallback then computed the major bump (from the feat! commit in range) on top of 3.0.0 instead of from the real pre-fork baseline, proposing 4.0.0. Rolling these back to 2.5.1 restores the state these files were in before the botched v3.0.0 release ever happened, so the next run computes the 2.5.1 -> 3.0.0 bump correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleting the broken `v3.0.0` release/tag without also resetting `version.txt` / `.release-please-manifest.json` / `Version.swift` back to `2.5.1` left the manifest still claiming the previous version was `3.0.0`. release-please's bootstrap fallback then computed the major bump (from the `feat!` commit in range) on top of `3.0.0` instead of from the real pre-fork baseline, proposing `4.0.0` (PR #23, closed unmerged — no bad release actually shipped).
Rolling these three files back to `2.5.1` restores the state they were in before the botched v3.0.0 release happened, so the next release-please run computes `2.5.1 -> 3.0.0` correctly.