feat(stovepipe): add request logs for dlq outcomes - #667
Open
mnoah1 wants to merge 1 commit into
Open
Conversation
Summary: This PR builds on #666, which records normal request outcomes and lifecycle events. Intent: - Retain the terminal reason when an exhausted pipeline stage forces a request to fail. - Repair a missing failure occurrence when DLQ reconciliation redelivers after the request write. Changes: - Record processing_failed for Process and Build DLQ reconciliation. - Record build_polling_exhausted for BuildSignal DLQ reconciliation. - Persist the failed request state before its log and preserve all other terminal outcomes. - Wire the shared request-log materializer into the three DLQ controllers. Test Plan: - Exercise new failure logging, retry repair, write ordering, stage-specific reasons, and server wiring in Bazel tests. Revert Plan: - Revert this change to leave DLQ reconciliation state-only. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
This was referenced Sep 2, 2026
mnoah1
marked this pull request as ready for review
September 2, 2026 22:50
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
September 2, 2026 22:50
mnoah1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on #666, which records normal request outcomes and lifecycle events.
Intent:
Changes:
Test Plan
Revert Plan
Generated by the 🪄 pr-create skill in devexp-agent-marketplace
Issues
Stack