Skip to content

chore(deps): bump tx3-sdk to 0.13.0#52

Merged
scarmuega merged 1 commit into
mainfrom
chore/bump-tx3-sdk-0.13.0
Jun 17, 2026
Merged

chore(deps): bump tx3-sdk to 0.13.0#52
scarmuega merged 1 commit into
mainfrom
chore/bump-tx3-sdk-0.13.0

Conversation

@scarmuega

@scarmuega scarmuega commented Jun 17, 2026

Copy link
Copy Markdown
Member

What

Brings cshell's tx3-sdk dependency up to date: 0.9.2 → 0.13.0 (latest published on crates.io), and adapts to the SDK's API changes along the way.

Changes

  • Cargo.toml / Cargo.locktx3-sdk = "0.13.0". The re-resolve also moves pallas from 1.0.0-alpha.3 to the stable 1.1.0 line, which tx3-sdk 0.13.0 requires.
  • src/tx/invoke.rsBytesEnvelope's encoding: BytesEncoding::Hex field became content_type: String in 0.13.0; submit now passes content_type: "hex" (matching the SDK's own convention) and drops the removed BytesEncoding import.
  • src/reports.rsMissingTxArgDiagnostic.ty.arg_type (field rename).
  • src/wallet/types.rs — pallas-crypto 1.x moved SecretKey::new / SecretKeyExtended::new to rand_core 0.10, but cshell stays on rand_core 0.9 for bip39/bip32 and private-key encryption (the mix is required, not a bug). The private_key_encryption_roundtrip test now builds its keys from bytes via the existing byte constructors instead.

The trp::Error match in reports.rs and the ParamType match in common.rs needed no changes — the error enum is unchanged in 0.13.0, and the new ParamType variants are absorbed by the existing _ => arm.

Verification

  • cargo build — clean
  • cargo clippy --all-targets — no new warnings
  • cargo test — 6/6 pass (incl. private_key_encryption_roundtrip)
  • cshell tx invoke --help — SDK-linked invoke path builds, links, and parses

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Dependencies
    • Updated tx3-sdk dependency to version 0.13.0.

Updates the `tx3-sdk` dependency from 0.9.2 to the latest published
release, 0.13.0, and adapts to its API changes:

- `BytesEnvelope`'s `encoding: BytesEncoding` field became
  `content_type: String`; submit now passes `content_type: "hex"`
  (matching the SDK's own convention) and drops the removed
  `BytesEncoding` import.
- `MissingTxArgDiagnostic.ty` was renamed to `arg_type`.

The bump also pulls pallas up to the stable 1.x line, whose
`pallas-crypto` moved key generation to `rand_core` 0.10. cshell
otherwise stays on `rand_core` 0.9 (bip39/bip32, private-key
encryption), so the `private_key_encryption_roundtrip` test now builds
its test keys from bytes via the existing byte constructors instead of
`SecretKey::new`/`SecretKeyExtended::new`.

The `trp::Error` match and the `ParamType` match needed no changes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Bumps the tx3-sdk dependency from 0.9.2 to 0.13.0 and updates three call sites to match the new API: renames x.ty to x.arg_type in the MissingTxArg error report, replaces BytesEncoding::Hex with a content_type: "hex" string field on BytesEnvelope, and rewrites wallet encryption tests to construct keys from raw bytes with explicit clamping.

Changes

tx3-sdk 0.13.0 API adaptation

Layer / File(s) Summary
Dependency bump and API call site changes
Cargo.toml, src/tx/invoke.rs, src/reports.rs
Updates tx3-sdk to 0.13.0; removes BytesEncoding import and sets content_type: "hex" on BytesEnvelope; switches MissingTxArg error report to read x.arg_type instead of x.ty.
Wallet key construction test adaptation
src/wallet/types.rs
Replaces SecretKey::new / SecretKeyExtended::new constructors with RNG-filled byte arrays passed to from_bytes; adds explicit bit-clamping for the extended key variant in the encryption roundtrip test.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 A version bumped, the fields renamed anew,
arg_type where once ty grew,
content_type: "hex" strings now say,
And clamped bits clamp in their proper way.
Hop hop—the SDK slides right through! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: bumping the tx3-sdk dependency from 0.9.2 to 0.13.0, which is the primary focus of this pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-tx3-sdk-0.13.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@scarmuega scarmuega merged commit d2d1f98 into main Jun 17, 2026
8 of 10 checks passed
@scarmuega scarmuega deleted the chore/bump-tx3-sdk-0.13.0 branch June 17, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant