Skip to content

[pull] master from ruby:master#1052

Merged
pull[bot] merged 11 commits into
turkdevops:masterfrom
ruby:master
May 26, 2026
Merged

[pull] master from ruby:master#1052
pull[bot] merged 11 commits into
turkdevops:masterfrom
ruby:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented May 26, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

dak2 and others added 11 commits May 26, 2026 14:14
Closes ruby/prism#4112

Also see ruby/prism#2501, for which this was done.
The expectation in rubocop is incorrect (produces code with semantic difference), so the test should be updated instead.

In any way, it should also have applied to `+`, where the same happens

ruby/prism@1f8cae2a75
No more usages outside re.c, so let's clean it up. Thanks to @nobu for
noticing!
The owner could be different from the housing class when the housing
module is prepended.
Previously, the last push, in case the total number of pushes was odd,
ended up in a different location relative to the stack top on x64 versus
A64. On A64, it ends up at `sp[0]`, whereas on x64 it ends up at
`sp[1]`. The difference was due to `CPush` not having consistent
architectural effects in the two arches.

Normalize to `CPushPair` instead. Now A64 will write one more slot, due
to using STP. x64 now uses the two-byte `push 0` instead of the
one-byte `push rdi`. The odd push now always lives at `sp[1]`, leaving
no gap between it and the rest of the survivors. This consistency will
benefit future stack map work.

Also remove some pointless `Vec` allocations.
@pull pull Bot locked and limited conversation to collaborators May 26, 2026
@pull pull Bot added the ⤵️ pull label May 26, 2026
@pull pull Bot merged commit ce7f3ed into turkdevops:master May 26, 2026
1 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants