Align monaco-code-editor with Cosmos repo conventions and switch library build to tsup#30
Open
anil08607 wants to merge 1 commit into
Open
Align monaco-code-editor with Cosmos repo conventions and switch library build to tsup#30anil08607 wants to merge 1 commit into
anil08607 wants to merge 1 commit into
Conversation
…ary build to tsup
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rushabhcodes
requested changes
Jul 12, 2026
rushabhcodes
left a comment
Contributor
There was a problem hiding this comment.
@anil08607 use order-dialog for ref, this is a componemt lib, it exports src directly, dont change that. afk rn take review from @imrishabh18 @mohan-bee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
buildstep, which only typechecked, with a realtsuplibrary builddist/instead of exporting rawsrc/filestsup.config.tswith browser-targeted ESM output, declarations, sourcemaps, and CSS inclusionstart,build:site,cosmos-export, andvercel-builddist/index.js,dist/index.d.ts, and the generated stylesheetWhy We Changed This
buildwas not producing a distributable packagesrc/index.tsdirectly is inconsistent with sibling repos and can break downstream consumers expecting built JS and type declarationspcb-viewerand similar repos already separate concerns cleanly:cosmosandcosmos-exportfor demos and site checkstsupfor npm package output