Repository navigation
Pin ruff version in the lint workflow - #23
Merged
martinlocklear merged 1 commit intoJul 27, 2026
Merged
Conversation
The ruff-action step ran unpinned with no in-repo ruff config, so CI installed the newest ruff at run time. A later ruff release then failed lint on unchanged code across the repo. Pin the ruff binary to a known-good version so the check is deterministic and a future release cannot turn lint red on its own. [authored by Cursor] Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
[authored by Cursor] While addressing review feedback on a sibling PR (trufflesecurity/.github#22), its lint check went red although the change was clean. Root cause: the Lint workflow's ruff-action runs unpinned with no in-repo ruff config, installing the latest ruff at run time; ruff 0.16.0 (released after that PR opened) enabled new default rules that flag 7 pre-existing findings repo-wide. This PR pins ruff to 0.15.22 (last known-good) so lint is deterministic. Key decisions
Alternatives considered
Background: pin-ruff-lint-ci-drift plan doc. |
sysread
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[authored by Cursor]
Summary
astral-sh/ruff-action@v4.0.0toversion: '0.15.22'on both thecheckandformat --checksteps in.github/workflows/lint.yml.Motivation
The action ran unpinned with no in-repo ruff config, so CI installed the newest ruff at run time. ruff 0.16.0 turned lint red across the repo on pre-existing code (7 findings) that 0.15.22 passed. Pinning makes the check deterministic - a ruff release can no longer break every PR's lint on its own.
Out of scope: adopting 0.16.0's stricter rules (fixing the 7 findings) or adding an in-repo ruff config; either can follow.
Test plan
ruff check .github/scriptsandruff format --check .github/scriptsclean at 0.15.22actionlintclean on the workflowPython (ruff)green on the PRTracked in INT-813.
Background: plan doc.