Skip to content

Add replica count support to tvc deploy create - #231

Draft
emostov wants to merge 1 commit into
mainfrom
zeke/tvc-deploy-replicas
Draft

Add replica count support to tvc deploy create#231
emostov wants to merge 1 commit into
mainfrom
zeke/tvc-deploy-replicas

Conversation

@emostov

@emostov emostov commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What

tvc deploy create now supports specifying a desired replica count, defaulting to 1:

  • --replicas <N> flag / TVC_REPLICAS env var, overriding the config file like the other flags
  • replicas field in the deploy config file; tvc deploy init templates include "replicas": 1
  • The create intent always sends an explicit replica count (previously omitted, leaving it to the server default)
  • A count of 0 is rejected client-side with a clear validation error

Notes

  • Config files written before the replicas field existed keep working (serde default of 1).
  • Seeding a config from an existing deployment defaults to 1 replica since the fetched deployment doesn't carry its desired replica count.

Testing

  • cargo test (all suites pass), cargo clippy --all-targets --all-features -D warnings clean.
  • New tests: replicas default, flag-overrides-file, zero rejection, intent wiring, backward-compat deserialization.

🤖 Generated with Claude Code

@emostov
emostov force-pushed the zeke/tvc-deploy-replicas branch from 835f72b to 8aa16c8 Compare August 5, 2026 17:15
@emostov
emostov changed the base branch from main to zeke/sync-protos-from-mono August 5, 2026 17:15
@emostov
emostov force-pushed the zeke/tvc-deploy-replicas branch from 8aa16c8 to 2470bf0 Compare August 5, 2026 17:27
@emostov emostov mentioned this pull request Aug 5, 2026
Comment thread tvc/src/commands/deploy/create.rs
Comment thread tvc/src/config/deploy.rs Outdated
@emostov
emostov changed the base branch from zeke/sync-protos-from-mono to main August 5, 2026 18:54
@emostov
emostov force-pushed the zeke/tvc-deploy-replicas branch from 2470bf0 to fcdf209 Compare August 5, 2026 19:21
@emostov
emostov marked this pull request as ready for review August 5, 2026 20:33
@emostov
emostov requested a review from daniilrrr August 5, 2026 21:51
Comment thread tvc/src/config/deploy.rs
Comment thread tvc/src/commands/deploy/create.rs
@emostov
emostov force-pushed the zeke/tvc-deploy-replicas branch 2 times, most recently from 24f4c81 to 7b43054 Compare August 6, 2026 04:09
daniilrrr
daniilrrr previously approved these changes Aug 6, 2026

@daniilrrr daniilrrr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with nits

Comment thread tvc/src/commands/deploy/init.rs Outdated
Comment thread tvc/src/config/deploy.rs Outdated
daniilrrr
daniilrrr previously approved these changes Aug 7, 2026
@emostov
emostov force-pushed the zeke/tvc-deploy-replicas branch 2 times, most recently from 74c931f to 82ca392 Compare August 7, 2026 20:32
@emostov
emostov requested a review from a team as a code owner August 7, 2026 20:32
…ono with a vendored serde-capable google.protobuf.Timestamp
@emostov
emostov force-pushed the zeke/tvc-deploy-replicas branch from 82ca392 to 289fddc Compare August 7, 2026 20:34
@emostov
emostov marked this pull request as draft August 7, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants