feat(generic-service): add initContainer support to worker deployment#83
Open
Glenn-Ewing wants to merge 1 commit into
Open
feat(generic-service): add initContainer support to worker deployment#83Glenn-Ewing wants to merge 1 commit into
Glenn-Ewing wants to merge 1 commit into
Conversation
Mirrors the existing frontend-deployment.yaml pattern so workers can gate startup on a pre-flight check (e.g. Django showmigrations --check). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initContainersupport toworker-deployment.yaml, matching the identical pattern already infrontend-deployment.yaml$value.initContainer.enabled == trueso it's opt-in and backwards-compatible with all existing worker configsWhy
The communications-service migration guard (
showmigrations --check) is being moved from the PHP frontend deployment to the Python worker deployments as PHP is deprecated. This template change is required to support that.Test plan
initContainer.enabled: truerenders the initContainers block in the generated manifestinitContainerset renders cleanly with no initContainers blockDepends on: devops-cicd PR that moves the migration guard from
frontend-outo the four Python workers (giving-worker,messaging-worker,communications-worker,sites-worker) — that PR needs this chart version published before the helmrelease version can be bumped.🤖 Generated with Claude Code