fix #133#135
Merged
Merged
Conversation
dbrakenhoff
commented
Jun 12, 2026
dbrakenhoff
commented
Contributor
- swap argument order for z and c for Model class. this class wasn't used much, so hopefully okay.
- this is now in line with the rest of the Model classes.
- plotting should be simplified in a separate issue
- wasn't used much, so hopefully okay. - this is now in line with the rest of the Model classes.
- fix unit dicts
- fix typo
This was
linked to
issues
Jun 18, 2026
mbakker7
approved these changes
Jun 19, 2026
mbakker7
left a comment
mbakker7
left a comment
Contributor
There was a problem hiding this comment.
I think this is ready to go. Looks nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.