[PMREQ-810] Let kube-controllers watch Networks - #5148
Merged
Conversation
The node controller's ipam_ippool_reserved metric now discounts an L2 Network's subnet edges and gateways as well as IPReservations, so it watches Network on its syncer. Without the verb the List still succeeds and the syncer reaches in-sync, so the symptom is a hot re-list rather than a stalled controller. Network is Enterprise / Cloud only, so the rule goes in the Enterprise common rules. CORE-13146 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
fasaxc
added
docs-not-required
release-note-not-required
enterprise
fasaxc
changed the title
caseydavenport
approved these changes
Aug 7, 2026
fasaxc
added a commit
to fasaxc/operator
that referenced
this pull request
Aug 13, 2026
The node controller's ipam_ippool_reserved metric now discounts an L2 Network's subnet edges and gateways as well as IPReservations, so it watches Network on its syncer. Without the verb the List still succeeds and the syncer reaches in-sync, so the symptom is a hot re-list rather than a stalled controller. Network is Enterprise / Cloud only, so the rule goes in the Enterprise common rules. CORE-13146 Co-authored-by: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 1f3d8a7)
fasaxc
added a commit
that referenced
this pull request
Aug 13, 2026
The node controller's ipam_ippool_reserved metric now discounts an L2 Network's subnet edges and gateways as well as IPReservations, so it watches Network on its syncer. Without the verb the List still succeeds and the syncer reaches in-sync, so the symptom is a hot re-list rather than a stalled controller. Network is Enterprise / Cloud only, so the rule goes in the Enterprise common rules. CORE-13146 (cherry picked from commit 1f3d8a7) Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kube-controllers'
ipam_ippool_reservedmetric reports how many addresses in each IP pool cannot be assigned. It already coversIPReservations; a companion calico-private PR extends it to an L2 bridgeNetwork's subnet edges (the network and directed-broadcast address) and gateways, which are unassignable for the same reason. The node controller therefore watchesNetworkon its syncer, alongsideIPReservation.That needs
listandwatchonnetworksin the kube-controllers ClusterRole.Networkis Enterprise / Cloud only, so the rule goes inkubeControllersRoleEnterpriseCommonRules, following the precedent inpkg/render/node.go.This needs to merge before the calico PR. Without the verb kube-controllers gets a 403 listing
networks, andwatcherCacheonly treats a missing CRD (404) as in-sync — a denied list takes the generic retry path without finishing the resync. The DataFeed then never reachesInSync, and every controller on it stalls, including auto host endpoints and the IPAM garbage collector. Calico CI demonstrated it as a[Feature:AutoHEPs]e2e failure.Testing: the existing kube-controllers render tests, whose ClusterRole rule counts move by one.
Calico side: https://github.com/tigera/calico-private/pull/13102
CORE-13146
Release Note
🤖 Generated with Claude Code