Publish widget CDN releases to Azure - #17
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fa052f179
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import type { WidgetState, WidgetSessionResponse } from './types' | ||
|
|
||
| const DEFAULT_RINGTONE_URL = 'https://storage.googleapis.com/thunderphone-widget-cdn/widget/assets/ringtone-default.mp3' | ||
| const DEFAULT_RINGTONE_URL = 'https://stthunderphoneprod.z13.web.core.windows.net/widget/assets/ringtone-default.mp3' |
There was a problem hiding this comment.
Serve default ringtone from a CORS-capable origin
This change points DEFAULT_RINGTONE_URL at the Azure static website endpoint, but the hook always loads ringtone audio with audio.crossOrigin = 'anonymous' (same file), which requires a valid Access-Control-Allow-Origin response for cross-origin embeds. Azure Storage static website endpoints (*.web.core.windows.net) do not provide configurable CORS headers, so when integrators enable ringtone: true from a different site origin, the browser can block the ringtone fetch and it will not play.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 1.1.1-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
End-to-end release proof completed. Verification:
Release auth configured:
|
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Verification
npm ci && npm run lint && npm test && npm run buildgit diff --checkFollow-up Required Before Release
AZURE_CLIENT_ID_PRODUCTION,AZURE_TENANT_ID,AZURE_SUBSCRIPTION_ID_PRODUCTION.autophonix/thunderphone-widgetrelease refs (mainandbeta) to the production GitHub Azure app/service principal.stthunderphoneprod.