fix(signing): publish round state before messages - #36
Merged
Merged
Conversation
Author
|
Final evidence at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The final full-suite race run found
TestRounds3to5CTWiringreading round-5 state concurrently withround5.Start.round5.Startemitted its outbound message before storingsi,rx, and the rest of its completed local state, so receiving the message did not synchronize those writes. The same publication-order variant existed forDTeldain round 7.Fix
Store all round-local state before publishing the corresponding outbound message in rounds 5 and 7. Wire bytes and arithmetic are unchanged.
Evidence
go test -race ./ecdsa/signing -run ^TestRounds3to5CTWiring$ -count=3go test -race -shuffle=on -count=1 ./ecdsa/signing