Repository navigation
Patch retained tooling dependencies and check caller compatibility - #197
Open
mswilkison wants to merge 1 commit into
Open
mswilkison wants to merge 1 commit into
mswilkison wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch advisory-affected dependencies that remain after #182 while retaining Hardhat 2 and Ethers 5. Use caller-scoped overrides for the legacy Axios clients, Hardhat HTTP/ZIP dependencies, Ethers WebSockets, Mocha serialization/diffs, and solc temporary files; update both YAML majors and the compatible parser dependencies. Axios 1.x callers remain on 1.x and ESLint retains YAML 3's API.
Add a separate local compatibility suite and run it in CI. It exercises actual Hardhat RPC/download paths and proxy connections, Ethers WebSocket requests/subscriptions, Mocha workers and assertion diffs, ZIP extraction, temporary files, the four legacy Axios callers, Express query/form parsing, and both YAML APIs.
Stacked on #182 (
chore/dependency-toolchain-refresh, base14843ac). Merge #182 first, then retarget this PR tomain. It is independent of the governance source fix in #196.Security coverage:
docs/dependency-security.adoc: 18 Solidity-library matches, cookie serialization unused by the retained Sentry parser, UUID buffer APIs unused by Hardhat'sv4(), and the unpatched elliptic truncation issue whose preconditions are absent from the retained secp256k1/32-byte signing callers. Hardcode grant stake owners in KeepStake library #26's custom quorum logic is addressed separately by Preserve historical proposal outcomes when quorum changes #196; this PR does not change Solidity dependencies.Validation:
CI passes on head
a6029c0: all 380 contract tests and 14 tooling integration tests, formatting, deployment dry run, documentation preview, and Slither.