fix(reservations): address validated review findings on #4343 by piotr-roslaniec · Pull Request #4346 · threshold-network/keep-core

fix(clientinfo): name vault fee reserve gauge in TBTC base units

piotr-roslaniec

committed

009cf3d

test(spv): return zero records for absent reservation keys and honour EndBlock in event fakes

piotr-roslaniec

committed

2fde8d3

build(tbtc): collapse verify-vendored-fallback into one ABI-diff macro

piotr-roslaniec

committed

aa13695

fix(tbtc): keep checkabi internalType unchanged when already spaced

piotr-roslaniec

committed

001c43d

chore(reservations): drop unused re-anchor event fee field and tidy docs

piotr-roslaniec

committed

78760a8

test(ethereum): cover action TermSeconds and MinAmount conversion

piotr-roslaniec

committed

2517c1a

fix(chain): pass the known vault address to reservation vault fee reads

piotr-roslaniec

committed

f391d9c

ci(tbtc): pin tbtc-v2 eec999aa and check the harness validator against it

piotr-roslaniec

committed

3085db1

refactor(reservations): drop re-anchor in-flight tracking and receipt lookup

piotr-roslaniec

committed

2e7eb37

feat(reservations): expose the re-anchor cooldown on tbtc.Reservation

piotr-roslaniec

committed

324cd92

test(ethereum): cover timeout margin, MovingFunds, caps and fees in validator harness

piotr-roslaniec

committed

b6d7f5f

fix(spv): scan reservation events from activation in resumable chunks behind the tip

piotr-roslaniec

committed

1a47748

test(tbtcpg): mirror Reservation.sol in the re-anchor request fake

piotr-roslaniec

committed

f13b8e8

fix(tbtcpg): re-anchor reservations from Closing source wallets

piotr-roslaniec

committed

0cbca48

fix(ethereum): compile the harness StubBridge by relative path for reproducible metadata

piotr-roslaniec

committed

cb72d01

fix(tbtc): locate anchor deposit reveals from reveal time, not a 30-day window

piotr-roslaniec

committed

f9cb95c

fix(tbtcpg): send at most one re-anchor request per Run pass

piotr-roslaniec

committed

5019414

fix(spv): submit one reservation proof per key per pass and drop unsettleable generations

piotr-roslaniec

committed

ff1254b

fix(tbtcpg): skip re-anchor requests the cooldown or anchor floor would revert

piotr-roslaniec

committed

c497786

refactor(spv): keep each tracked stale deposit's refund deadline in its pending entry

piotr-roslaniec

committed

4ee3587

perf(tbtcpg): search re-anchor targets once per Run pass

piotr-roslaniec

committed

99a6803

test(spv): wait for the watcher recover path in the typed-nil metrics test

piotr-roslaniec

committed

add36ce

test(tbtcpg): cover the re-anchor amount headroom pre-check and safety margin

piotr-roslaniec

committed

253271e

test(cmd): cover the Ethereum network handed to the SPV maintainer

piotr-roslaniec

committed

c575313

docs(spv): describe the shared reservation scan-start policy

piotr-roslaniec

committed

76dca4f

docs(tbtcpg): note the cooldown in the re-anchor resume margin comment

piotr-roslaniec

committed

07bbb04

test(spv): drain watcher recover paths before the death-hook tests end

piotr-roslaniec

committed

6519e63

Merge branch 'fix/m1-review-wp-a' into t3code/review-current-pull-request

piotr-roslaniec

committed

0aab992

Merge branch 'fix/m1-review-wp-c' into t3code/review-current-pull-request

piotr-roslaniec

committed

928caf7

fix(tbtcpg): discover acceptance candidates from depositor requests

piotr-roslaniec

committed

303d147

fix(tbtc): use the chain's block time when locating an anchor's deposit reveal

piotr-roslaniec

committed

0c1a261

test(tbtcpg): model budget fillers as settled generations and name tests by invariant

piotr-roslaniec

committed

9d7fe18

Merge branch 'fix/m1-review-wp-b' into t3code/review-current-pull-request

piotr-roslaniec

committed

2ffa901

fix(tbtcpg): scan acceptance requests in bounded chunks

piotr-roslaniec

committed

42bde46

Navigation Menu

fix(reservations): address validated review findings on #4343 - #4346

fix(reservations): address validated review findings on #4343#4346
piotr-roslaniec merged 34 commits into
reservations-epicfrom
fix/m1-review-followups

Commits on Sep 30, 2026

fix(clientinfo): name vault fee reserve gauge in TBTC base units

test(spv): return zero records for absent reservation keys and honour EndBlock in event fakes

build(tbtc): collapse verify-vendored-fallback into one ABI-diff macro

fix(tbtc): keep checkabi internalType unchanged when already spaced

chore(reservations): drop unused re-anchor event fee field and tidy docs

test(ethereum): cover action TermSeconds and MinAmount conversion

fix(chain): pass the known vault address to reservation vault fee reads

ci(tbtc): pin tbtc-v2 eec999aa and check the harness validator against it

refactor(reservations): drop re-anchor in-flight tracking and receipt lookup

feat(reservations): expose the re-anchor cooldown on tbtc.Reservation

test(ethereum): cover timeout margin, MovingFunds, caps and fees in validator harness

fix(spv): scan reservation events from activation in resumable chunks behind the tip

test(tbtcpg): mirror Reservation.sol in the re-anchor request fake

fix(tbtcpg): re-anchor reservations from Closing source wallets

fix(ethereum): compile the harness StubBridge by relative path for reproducible metadata

fix(tbtc): locate anchor deposit reveals from reveal time, not a 30-day window

fix(tbtcpg): send at most one re-anchor request per Run pass

fix(spv): submit one reservation proof per key per pass and drop unsettleable generations

fix(tbtcpg): skip re-anchor requests the cooldown or anchor floor would revert

refactor(spv): keep each tracked stale deposit's refund deadline in its pending entry

perf(tbtcpg): search re-anchor targets once per Run pass

test(spv): wait for the watcher recover path in the typed-nil metrics test

test(tbtcpg): cover the re-anchor amount headroom pre-check and safety margin

test(cmd): cover the Ethereum network handed to the SPV maintainer

docs(spv): describe the shared reservation scan-start policy

docs(tbtcpg): note the cooldown in the re-anchor resume margin comment

test(spv): drain watcher recover paths before the death-hook tests end

Merge branch 'fix/m1-review-wp-a' into t3code/review-current-pull-request

Merge branch 'fix/m1-review-wp-c' into t3code/review-current-pull-request

fix(tbtcpg): discover acceptance candidates from depositor requests

fix(tbtc): use the chain's block time when locating an anchor's deposit reveal

test(tbtcpg): model budget fillers as settled generations and name tests by invariant

Merge branch 'fix/m1-review-wp-b' into t3code/review-current-pull-request

fix(tbtcpg): scan acceptance requests in bounded chunks