[feat] 38 R11: one look from the tokens, no native scrollbars, flowbite out (38-cleanup)

[AlexZ005]

38 R11: one look from the tokens, no native scrollbars, flowbite out (38-cleanup)

Done when (ROADMAP R11): CI enforces the tokens. npm run check:tokens is now a hard fail in ci.yml, and two new lints guard the rest of R11.

This branch also merges the other 1.28 lanes first, as the brief asks: feat/38-int-a (tokens, lock, inspector, windows), then 38-icons, 38-modals, 38-hud and 38-mobile. 6ece8b21 removes the six duplicate Icon imports those merges produced.

Phases

1. Gates (ef6e19a4)
   • scripts/check-tokens.cjs hard-fails by default (--warn only reports).
   • Data colours are exempted with a tokens-ok: <reason> line pragma, or a tokens-ok-begin … tokens-ok-end block.
   • The five colliding tokens move from .tp-ui to :root, so light and custom themes reach every surface (NOTES-38 Feature/save-load #8).
   • app.css hides every platform scrollbar.
   • New lint tests/unit/noNativeScrollbars.test.js: every scroller must use use:minimalScroll or tp-noscrollbar, and no stylesheet may style a native bar (NOTES-38 Feature/sidebar-menu #1).
2. Migration (7f5ea5d4, 219 files)
   • Every component paints from the tokens.
   • The last orange selection and armed states become the one blue accent; orange (--live) stays for Play and recording.
   • Every scroller uses the minimal bar.
   • flowbite is removed from everything except the pending Settings files (see below). Users becomes a ModalDialog plus a native popover; Recording and ReplaceModel become ModalDialogs; Controls' Listgroup becomes a plain div.
   • New lint tests/unit/noFlowbite.test.js.
3. Dead CSS (dddf1ee4)
   • 38 theme.css remap selectors that no component uses any more are removed. The 20 that flowbite's own Modal, Button, Toggle and Checkbox themes still emit are kept, because the Settings window still uses flowbite.
   • hud.css .hud-dot and phone.css .resize-grip are removed.
4. Battery fixes (38ee96e5, d68a9f2e, d8ec45d5)
   • Profile menu closed the instant it opened (a regression from this branch). The menu's own avatar circle sits in the top layer over the trigger, so the opening click was counted as outside. "Outside" is now decided by where the press started.
   • Light theme:
     • The logo tile was transparent: a scoped .burger rule painted an undefined --color-form, and theme.css's !important remap used to hide that.
     • The default avatar silhouette vanished into the 3D scene; the circle over the viewport now has an opaque fill.
     • The colour-picker hex text inherited --border as its colour (1.1:1 contrast).
   • HUD editor:
     • The selected screen row now uses --accent-soft; --surface-active put the red ✕ at 2.3–2.9:1 in the exotic themes.
     • The stage stays dark in every theme, because it stands in for the 3D viewport (exempted with tokens-ok).
   • Notification sheet 44 px wide on phones (from the merges). 38-hud's .hud-tr glass uses backdrop-filter, which made the group the containing block for its fixed #notif-panel sheet and for #peers-popover. The glass moves to a ::before.
   • Lock fixture: fixtures/lock/shortcuts.json gains the help.palette row (38-hud's Ctrl+K, NOTES-38 Feature/connected-peers #14), added by hand rather than re-recorded. It was the only red in lock-shortcuts on the union.
5. svelte-check floor ratcheted from 318/47 to 312/41 (5855f25a).

Gates on the head

• check:tokens clean: 277 files, 13 pending another branch
• vitest 138 files / 1597 tests
• svelte-check 312/41 = the baseline
• vite build green

Behaviour lock and battery

• Lock suites on the head 5855f25a: all 8 green. lock-settings 263, lock-settings-b 345, lock-dragrow 383, lock-dragrow-sync 15, lock-shortcuts 154, lock-panels 126, lock-search 11, lock-objectlist 18. Also green on the head: mobile-map 81, mobile-ui-fixes 28, peers-popover 21.
• Colour and marker suites: 31 run. The reds were re-run as an A/B against the union snapshot 6ece8b21.
  • Fixed (they also failed on the union snapshot, but with fewer failures): mobile-ui-fixes, theme-text-sweep.
  • Fixed (green on the union snapshot, so introduced here): menu-keyboard-tab.
  • Fixed although it was already red on the union: mobile-map (the notification sheet above).
  • Already red on the union, identically, and not this lane's surface:
    • editor-ui-33 E3, the corner pixels beside Play (38-hud's well).
    • panel-shortcuts 3b.1, a stale premise: Animation has been on the default bar since 1.19.
    • file-preview "dragging really resizes": height +14 px only.
    • animation-curves "right-clicking a graph KEY cancels the browser menu": no contextmenu event is recorded at all.

Screenshots

Before/after pairs for 46 surfaces × 1440×900 and 390×844 × dark, light and custom are in lanes-30/after-38/38-cleanup/gallery/, named <surface>-<size>-<theme>-{before,after}.png.

Left for 38-int-b (QUESTIONS-38-cleanup Q1)

The 13 Settings files belong to 37-settings (core #335, 1.26). The gates skip them through one list, scripts/redesign-pending.json. When 1.26 merges:

1. Empty that list.
2. Swap Settings.svelte's <Modal> for ui/ModalDialog.
3. Fix the 5 raw colours 37-settings left.
4. Drop flowbite and flowbite-svelte from package.json, plus the @plugin/@source lines in app.css.
5. Re-run the gates.

Follow-ups / design calls

• VR panels keep their old orange hover/selection (three.js data). Reading a VR palette from the tokens at mount would finish them.
• Token wishes:
  • --on-scene / --scene-halo (would replace the HUD stage literal)
  • --shadow-color
  • --playhead
  • --on-warn
  • a success fill
  • role-badge hues
• Design calls the user may want to see:
  • the Explorer anchor and picked cards are both blue
  • 3D preview backgrounds follow the theme
  • timeline selected keys stay amber
  • the armed tp-seg uses accent-fill
  • the Users profile popover lost flowbite's 100 ms close fade

NOTES-38 applied: #1, #8, #9, plus #14 in the lock fixture.

🤖 Generated with Claude Code