Repository navigation
fix(icons): drives take Yaru's device artwork before the icon index - #65
Merged
thepathless merged 1 commit intoOct 12, 2026
Merged
Conversation
The icon index is theme-agnostic: the first file found under any theme wins, so drive-removable-media-usb resolved to Breeze's 16 px dark outline. Next to Yaru's folders it looked like a different icon set, and under the dot matrix it shrank to a few faint dots. Known device names now use Yaru's 256 px artwork, as folders do; other names still go through the index.
priard
added a commit
to priard/omadock
that referenced
this pull request
Oct 11, 2026
Owner
|
🎉 Thank you so much for this contribution, @priard! Really appreciate the care you put into it. ✨ Verified on experimental — static gates, unit suites (239 node + 116 python) and the full live dock battery all green, including the marks-centering suite — and merged. Your work is credited in the changelog. 🙏🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A mounted USB drive looked like it came from another icon set: next to Yaru's folders it showed a small dark outline, and under the dot matrix style it shrank to a few faint dots (the original showing through at partial strength was dark on a dark plate, so almost invisible).
resolveDriveIconasked the icon index first. That index is theme-agnostic (the first file found under any theme wins), so on a system with Breeze installeddrive-removable-media-usbresolved tobreeze/devices/16/drive-removable-media-usb.svginstead of Yaru's artwork, which folders use.Fix
Known device names (
drive-removable-media-usb,usb-pendrive,drive-removable-media,media-removable,drive-harddisk-usb,media-optical) now take Yaru's 256 px device artwork first, as folders do. Other names still go through the icon index. Non-Yaru themes and the monochrome folder colours keep Adwaita's symbolic outlines, unchanged.The unit test that asserted "the library wins over the hardcoded fallback" now asserts the new order and covers an unmapped name that still resolves through the index.
Testing
node --test tests/unit/*.mjs: 168/168tests/static/structure-check.pypasses