Conversation
Contributor
|
Heads-up: this branch predates #368, which dropped Pipeline from
The component change itself holds up — it reads |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Mount the existing command palette in both the project and organization layouts so Command+K and Ctrl+K open it.
Use the sidebar's project navigation list for the palette entries and remove the organization links to pages that no longer exist. Filtering, arrow-key selection and project switching still work. The usage guide now documents the shortcut.
This is a nonbreaking UI fix. It adds no dependencies and doesn't change stored data, APIs, permissions or budgets.
Why
Closes #355
The topbar shows a shortcut that does nothing because the palette is never mounted. Its old destinations also need updating before people can use it.
Verification
I ran the checks in a local Docker Sandbox microVM, with no host directories mounted.
All six Vitest/jsdom tests passed. They cover both layouts, existing routes, filtering, keyboard selection, organization navigation and project switching.
Web typecheck, the production build and
pnpm verifypassed.I also checked the production build in a browser with a local API fixture that returns fixed responses. All 16 checks passed, including opening and dismissing the palette, keyboard navigation, project switching and organization pages. There were no browser errors.
pnpm verifypasses locallyBehaviour verified beyond the test suite (say how)
Documentation updated, or no user-facing change