Conversation
adrian-lorenzo
approved these changes
Sep 14, 2026
adrian-lorenzo
left a comment
Member
There was a problem hiding this comment.
Thanks for improving keyboard navigation and accessibility.
Verified skip-link focus in both app shells at desktop and mobile widths, plus the login semantics. No blocking issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #331.
What changes
VisuallyHiddenprimitive to@facility/uimain-contentid andtabIndex={-1}so the destination can receive focus reliably<main>landmark, a real<h1>with visually hidden page-purpose text, and a descriptiveSign in · facilitydocument titlerenderToStaticMarkupregression coverage for the primitive, skip-link target, and login semanticsScope
This intentionally leaves the story-timeline announcement strategy for a separate follow-up. It also does not add axe coverage because #332 is already handling the automated accessibility guard.
Verification
main(c14bc6d)