Skip to content

fix(web): add baseline accessibility landmarks and skip navigation - #339

Open
ALVZ93 wants to merge 1 commit into
theam:mainfrom
ALVZ93:fix/a11y-baseline-331
Open

ALVZ93 wants to merge 1 commit into
theam:mainfrom
ALVZ93:fix/a11y-baseline-331

Conversation

@ALVZ93

@ALVZ93 ALVZ93 commented Sep 8, 2026

Copy link
Copy Markdown

Refs #331.

What changes

  • adds an exported VisuallyHidden primitive to @facility/ui
  • adds a keyboard-first skip link to both authenticated app shells
  • gives both skip-link targets a shared main-content id and tabIndex={-1} so the destination can receive focus reliably
  • gives the login page a <main> landmark, a real <h1> with visually hidden page-purpose text, and a descriptive Sign in · facility document title
  • adds deterministic renderToStaticMarkup regression coverage for the primitive, skip-link target, and login semantics

Scope

This intentionally leaves the story-timeline announcement strategy for a separate follow-up. It also does not add axe coverage because #332 is already handling the automated accessibility guard.

Verification

  • branch is based directly on current main (c14bc6d)
  • no dependencies or lockfile changes
  • no API, database, security, or money-sensitive surface touched
  • focused tests are included; repository CI is expected to run the full project checks on this PR

@adrian-lorenzo adrian-lorenzo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving keyboard navigation and accessibility.

Verified skip-link focus in both app shells at desktop and mobile widths, plus the login semantics. No blocking issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants