TS strict (3/3): runtime model/form/service changes + enable strict mode#3688
Open
tegan-temporal wants to merge 4 commits into
Open
TS strict (3/3): runtime model/form/service changes + enable strict mode#3688tegan-temporal wants to merge 4 commits into
tegan-temporal wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tegan-temporal
force-pushed
the
strict/3-behavior
branch
from
July 17, 2026 16:46
c174bec to
441f4e9
Compare
tegan-temporal
force-pushed
the
strict/2-mechanical
branch
from
July 17, 2026 16:46
81d60a7 to
71501db
Compare
Mechanical null-safety: nullish-coalescing defaults, optional chaining,
{#if} render guards, and generics-driven refactors. Behavior-preserving.
Rebased onto main after the base PR (#3686) merged.
WorkflowExecution optional fields (with their snapshot tests), schedule-form zod default seeding, standalone-activity retry fields as strings coerced at the boundary, duration-input defaults, and requestFromAPI's Promise<T | undefined>.
tegan-temporal
force-pushed
the
strict/2-mechanical
branch
from
July 17, 2026 17:36
c4adac5 to
8e9e26e
Compare
tegan-temporal
force-pushed
the
strict/3-behavior
branch
from
July 17, 2026 17:36
441f4e9 to
a6e10b3
Compare
Fold the strict: true flip + Danger warn->fail into this PR. The standalone-activity form's superForm types only resolve correctly under strictNullChecks, so the behavior changes can't type-check on a strict:false main — the flag must land with them. Supersedes the separate flag PR (#3640).
tegan-temporal
changed the title
tegan-temporal
marked this pull request as ready for review
July 17, 2026 21:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final PR of the strict-mode split (base #3686 and mechanical #3687 already merged).
Contains the genuine runtime-affecting changes and the
strict: trueflip, because they're coupled: the standalone-activity form's superForm types only resolve correctly understrictNullChecks, so this code can't type-check on astrict: falsemain — the flag has to land together with it. (Supersedes the separate flag PR #3640, now closed.)Promise<T | undefined>strict: trueintsconfig.jsonVerified:
svelte-checkreports 0 errors under strict on this branch.