a11y: run axe over Holocene stories in CI (report-only)#3683
Draft
ardiewen wants to merge 1 commit into
Draft
Conversation
Adds a Storybook a11y job that runs axe over every story (271) via the existing `stories:test` runner (@storybook/addon-a11y + axe-playwright), catching the per-component structural/name/contrast band that the Svelte compiler gate (#3682) cannot see. Report-only (`continue-on-error: true`): the current baseline isn't clean (13 failing tests across 6 components), so the job surfaces violations without blocking merge. Remove `continue-on-error` to make it a hard gate once the baseline is burned down. Uses `pnpm dlx` for the serve tooling (http-server/wait-on/concurrently) to avoid lockfile churn; vendor as devDeps when flipping to blocking. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Accessibility triageNo See DT-4048 for the triage system design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runs axe over every Holocene story (271) in CI, via the existing
stories:testrunner (@storybook/addon-a11y+ axe-playwright). This catches the per-component structural / name / contrast band that the Svelte compiler gate (#3682) structurally cannot see — the biggest single coverage gain for shift-left a11y, since fixing a primitive cascades to every consumer.Report-only for now (
continue-on-error: true): the baseline isn't clean, so the job surfaces violations in the log without blocking merge. Removecontinue-on-errorto make it a hard gate once the baseline below is burned down.Baseline to burn down — 13 failing tests / 6 components
aria-current,aria-required-parent/children,aria-disabledaria-disabled(29),aria-required-parent/children(8 — often isolated-render artifacts, i.e. a child role rendered without its required parent in the story),aria-current(6),color-contrast(2),label,button-name.Notes
pnpm dlxfor the serve tooling (http-server / wait-on / concurrently) to avoid lockfile churn — vendor them as devDeps when flipping to blocking.🤖 Generated with Claude Code