implement time skipping for schedule v2 - #12197
Open
feiyang3cat wants to merge 5 commits into
Open
feiyang3cat wants to merge 5 commits into
feiyang3cat wants to merge 5 commits into
Conversation
feiyang3cat
added this pull request to stack #12198
September 20, 2026 18:28
feiyang3cat
force-pushed
the
fx/vts-chasm-schedule
branch
3 times, most recently
from
September 20, 2026 19:00
502c84d to
2ce1494
Compare
feiyang3cat
commented
Sep 20, 2026
feiyang3cat
commented
Sep 20, 2026
feiyang3cat
force-pushed
the
fx/vts-chasm-framework-patch
branch
from
September 21, 2026 07:44
37aaccd to
cd44882
Compare
feiyang3cat
force-pushed
the
fx/vts-chasm-schedule
branch
8 times, most recently
from
September 26, 2026 17:37
4ff7f75 to
4af3bb1
Compare
feiyang3cat
force-pushed
the
fx/vts-chasm-schedule
branch
4 times, most recently
from
September 27, 2026 05:08
35c5a98 to
5dd3dce
Compare
feiyang3cat
commented
Sep 27, 2026
feiyang3cat
force-pushed
the
fx/vts-chasm-schedule
branch
3 times, most recently
from
September 27, 2026 06:07
084bb06 to
13e0234
Compare
feiyang3cat
commented
Sep 27, 2026
| return &schedulerpb.MigrateToWorkflowResponse{}, nil | ||
| } | ||
|
|
||
| _, timeSkippingState := ctx.GetTimeSkippingPropagateState() |
Member
Author
There was a problem hiding this comment.
for reviews: need special attention for this handling if this will impact the migration plan unexpectedly
feiyang3cat
commented
Sep 27, 2026
| }, workflow.RegisterOptions{Name: wt}) | ||
| } | ||
|
|
||
| // registerTimerWorkflow registers a workflow with exactly one user timer. |
Member
Author
There was a problem hiding this comment.
Current necessary test coverage:
- Frontend validation: dynamic-config gate, V1 rejection, required/bounded fast-forward.
- Scheduler gate: status, generator, backfiller, all overlap policies, buffered/running work, cancellation and termination.
- Invoker: config/state propagation and virtual-vs-wall start timestamps.
- Migration: enabled or previously-skipped Schedules are blocked; allowed migration propagates no time-skipping fields.
- API wiring: create/update configuration and Describe output.
- Functional: fast-forward, default overlap with a user timer, and BUFFER_ALL with backfill and user timers.
- Existing Schedule functional tests provide broad regression coverage with time skipping unset.
Focused Scheduler, common, and frontend tests pass.
feiyang3cat
force-pushed
the
fx/vts-chasm-schedule
branch
from
September 27, 2026 06:22
13e0234 to
484ad7d
Compare
feiyang3cat
marked this pull request as ready for review
September 27, 2026 06:22
feiyang3cat
force-pushed
the
fx/vts-chasm-framework-patch
branch
from
September 29, 2026 16:49
93bee2b to
0abfbb0
Compare
feiyang3cat
force-pushed
the
fx/vts-chasm-schedule
branch
from
September 29, 2026 17:02
484ad7d to
2b54fa6
Compare
feiyang3cat
force-pushed
the
fx/vts-chasm-framework-patch
branch
from
September 29, 2026 17:20
0abfbb0 to
5d8f408
Compare
feiyang3cat
removed this pull request from stack #12198
September 29, 2026 17:21
feiyang3cat
force-pushed
the
fx/vts-chasm-schedule
branch
from
September 29, 2026 18:04
2b54fa6 to
4a85881
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
How did you test it?
need to merge the API first and change dependance to main temporalio/api#856