use Patch when adding/removing finalizer#369
Merged
Merged
Conversation
To prevent TWC from mistakenly stealing ownership of an existing WorkerDeployment, we use `Patch()` instead of `Update()` when adding and removing the finalizer on WorkerDeployment. Issue temporalio#317 Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
Shivs11
approved these changes
Jun 9, 2026
Shivs11
left a comment
Shivs11
left a comment
Member
There was a problem hiding this comment.
i wonder: could we test this out in any possible way?
Contributor
Author
@Shivs11 I had the same thought. :) But I did not see any existing unit or functional tests that I could copy to add this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent TWC from mistakenly stealing ownership of an existing WorkerDeployment, we use
Patch()instead ofUpdate()when adding and removing the finalizer on WorkerDeployment.Issue #317