chore: add ramping percentage to worker deployment routing helper#459
Open
chris-olszewski wants to merge 1 commit into
Open
chore: add ramping percentage to worker deployment routing helper#459chris-olszewski wants to merge 1 commit into
chris-olszewski wants to merge 1 commit into
Conversation
chris-olszewski
force-pushed
the
olszewski/chore_worker_version_flake_fix
branch
from
ff6f269 to
e879d38
Compare
chris-olszewski
force-pushed
the
olszewski/chore_worker_version_flake_fix
branch
from
e879d38 to
296788b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Leverage
wait_for_worker_deployment_routing_config_propagationin all of our worker versioning tests to reduce flakes.Add
expected_ramping_percentageto ourwait_for_worker_deployment_routing_config_propagationhelper to avoid some flakes.Why?
Had these tests flake for me on another PR.
Copying temporalio/sdk-typescript#2089 which seems to have resolved flakes around the worker versioning tests.
Checklist
Closes N/A
How was this tested:
CI
Any docs updates needed?
N/A