Skip to content

Fix incorrect outcome check for polling in update_with_start#457

Merged
GregoryTravis merged 6 commits into
mainfrom
gmt/update-validator-polls
Jun 9, 2026
Merged

Fix incorrect outcome check for polling in update_with_start#457
GregoryTravis merged 6 commits into
mainfrom
gmt/update-validator-polls

Conversation

@GregoryTravis

Copy link
Copy Markdown
Contributor

Fix execute_update_with_start_workflow raising RPCError NOT_FOUND on validator rejection

Fixes #454.

Bug

When a workflow_update_validator rejects an update sent via
execute_update_with_start_workflow, the caller received
Temporalio::Error::RPCError with code NOT_FOUND instead of
Temporalio::Error::WorkflowUpdateFailedError carrying the validator's
exception as cause.

Root cause

The outcome-present check sense was wrong, so it did a history poll for the outcome that it already had and would not get from history, resulting in an RPCError..

Test: test_update_with_start_validator_rejection

@GregoryTravis GregoryTravis requested a review from a team as a code owner June 9, 2026 15:40
@chris-olszewski

Copy link
Copy Markdown
Member

We should add this fix to the changelog

@GregoryTravis GregoryTravis changed the title Fix incorrect outcome check for polling in upddate_with_start Fix incorrect outcome check for polling in update_with_start Jun 9, 2026
@GregoryTravis GregoryTravis merged commit ee86133 into main Jun 9, 2026
7 checks passed
@GregoryTravis GregoryTravis deleted the gmt/update-validator-polls branch June 9, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] execute_update_with_start_workflow raises RPCError NOT_FOUND when workflow update validator rejects

2 participants