Set request ID for SAA - #1761
Merged
Merged
Conversation
maciejdudko
approved these changes
Aug 17, 2026
dandavison
reviewed
Aug 17, 2026
| service_client.workflow_service.start_activity_execution = start_activity_execution | ||
| client = Client(service_client) | ||
|
|
||
| for activity_id in ("activity-id-1", "activity-id-2"): |
Contributor
There was a problem hiding this comment.
nit...
Suggested change
| for activity_id in ("activity-id-1", "activity-id-2"): | |
| for activity_id in ["activity-id-1", "activity-id-2"]: |
Contributor
There was a problem hiding this comment.
What do you have against tuples?
Contributor
There was a problem hiding this comment.
A tuple is for holding a collection of slots, each of which has a distinct meaning, such as (x_coord, y_coord) or (age, sex, height). This is just an iterable of homogeneously-typed values which should be represented as a list in python.
Quinn-With-Two-Ns
enabled auto-merge (squash)
August 18, 2026 00:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Set request ID for SAA.
Why?
Set request ID for SAA so retried requests are not duplicate.
Checklist
Closes
How was this tested:
Note
Low Risk
Small client RPC field change with Nexus override preserved; low blast radius and covered by a focused unit test.
Overview
Standalone activity starts (
Client.start_activity) now populateStartActivityExecutionRequest.request_idwith a fresh UUIDv4 on each call, aligning with other client start RPCs and letting the server deduplicate retriedStartActivityExecutioncalls instead of creating duplicate executions.Nexus-backed activity starts still override that field via
_apply_nexus_context_to_start_activity_requestso retries across the Nexus boundary keep the inbound request ID. A unit test asserts each standalone start gets a valid, distinctrequest_id.Reviewed by Cursor Bugbot for commit 28637d0. Bugbot is set up for automated code reviews on this repo. Configure here.