Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,15 @@ private PayloadValidationException() {}
/**
* Creates a non-retryable failure containing payload validation details.
*
* <p>The details are stored as a single value and serialized by the configured {@link
* DataConverter}.
* <p>Non-null details are stored as a single value and serialized by the configured {@link
* DataConverter}. If details are null, the failure has no detail values.
*
* @param details payload validation details
*/
public static ApplicationFailure newPayloadValidationException(Object details) {
if (details == null) {
return ApplicationFailure.newNonRetryableFailure(MESSAGE, TYPE);
}
return ApplicationFailure.newNonRetryableFailure(MESSAGE, TYPE, details);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,18 @@
import org.junit.Test;

public class PayloadValidationExceptionTest {
@Test
public void newPayloadValidationExceptionWithNullDetailsHasNoDetails() {
ApplicationFailure applicationFailure =
PayloadValidationException.newPayloadValidationException(null);

assertEquals(0, applicationFailure.getDetails().getSize());

DataConverter dataConverter = DefaultDataConverter.STANDARD_INSTANCE;
Failure encodedFailure = dataConverter.exceptionToFailure(applicationFailure);
assertEquals(0, encodedFailure.getApplicationFailureInfo().getDetails().getPayloadsCount());
}

@Test
public void
newPayloadValidationExceptionReturnsNonRetryableApplicationFailureWithEncodedDetails() {
Expand Down
Loading