fix(tektonaddon): use zip format for Windows CLI downloads - #4056
fix(tektonaddon): use zip format for Windows CLI downloads#4056pratap0007 wants to merge 1 commit into
Conversation
Change Windows tkn binary download links from .tar.gz to .zip format. CLI publishes windows binaries as .zip archives and Windows users expect .zip archives for CLI tools. Updating the download links will ensure consistency with the published CLI artifacts. Signed-off-by: pratap0007 <shverma@redhat.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
|
@pratap0007 did you update the tkn-serve-cli as well for these zip files ? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4056 +/- ##
=======================================
Coverage 26.44% 26.44%
=======================================
Files 465 465
Lines 24992 24992
=======================================
Hits 6610 6610
Misses 17661 17661
Partials 721 721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
@pramodbindal No, I will update it now |
|
/approve |
tekton-robot
added
the
approved
|
@mathur07: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil, mathur07 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Change Windows tkn binary download links from .tar.gz to .zip format. CLI publishes Windows binaries as .zip archives and Windows users expect .zip archives for CLI tools.
Updating the download links will ensure consistency with the published CLI artifacts.
CLI Windows binaries release format: https://github.com/tektoncd/cli/blob/16e95eb4c447deee42c8c1b715a182d0ac531830/.goreleaser.yml#L31
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes