Rename TektonScheduler to TektonKueue - #3809
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3809 +/- ##
==========================================
+ Coverage 26.95% 27.26% +0.30%
==========================================
Files 467 475 +8
Lines 25170 25428 +258
==========================================
+ Hits 6785 6932 +147
- Misses 17648 17745 +97
- Partials 737 751 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
As you mentioned this is breaking change. we need to provide some backward compatibility. Something like. If you can keep the dummy TektonScheduler for some releases so existing TektonScheduler field does not create any issue and if present we need to move the config to TektonKueue. |
|
@waveywaves - do we wait until the tekton-kueue project is moved to tektoncd org? |
for what is worth, it has moved in tektoncd org today 😛 |
Thank you 😄 @waveywaves could you update the import pkg references and components.yaml references. Thank you |
5441998 to
aad0734
Compare
aad0734 to
96026cb
Compare
96026cb to
fe54ca5
Compare
khrm
left a comment
There was a problem hiding this comment.
Did you run this in OpenShift? Is it working?
|
@waveywaves
|
fe54ca5 to
afdacc8
Compare
afdacc8 to
5a5070c
Compare
|
@pramodbindal @khrm I rebased the PR onto current The compatibility path now retains the deprecated CRD and Upgrade matrix from Operator v0.81.1 to this PR head (
The upgrade runs also exposed two issues that are now fixed and covered: a missing Local I also ran the representative custom-queue upgrade through the raw OpenShift manifests on OpenShift 4.20.33/Kubernetes v1.33.13. The apply-to-ready phase completed in 132 seconds: the queue was preserved, |
|
cc @jkhelil |
5a5070c to
1e28416
Compare
|
@khrm @pramodbindal Could you please take another look? |
|
I think we shoudl merge this since it was tested in OpenShift. |
khrm
left a comment
There was a problem hiding this comment.
/approve
@waveywaves Please rebase.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rename the component API, controllers, clients, CRDs, manifests, and documentation to match Tekton Kueue. Retain the deprecated TektonScheduler API and TektonConfig scheduler field for upgrade compatibility. Pre-upgrade reconciliation migrates legacy configuration and resources to TektonKueue, preserves queue configuration, and removes obsolete InstallerSets, RBAC, and resources. Use tektoncd/tekton-kueue for repository and release references. Keep Go imports on github.com/konflux-ci/tekton-kueue because v0.4.0 still declares that module path. BREAKING CHANGE: TektonScheduler and TektonConfig.spec.scheduler are deprecated in favor of TektonKueue and TektonConfig.spec.kueue. Image overrides now use IMAGE_KUEUE_MANAGER and IMAGE_KUEUE_WEBHOOK. Signed-off-by: waveywaves <11972233+waveywaves@users.noreply.github.com>
Cover explicit Kueue precedence, refresh generated CRD, Helm, and OpenShift bundle artifacts, and drop a duplicate bundle CRD. Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com> Assisted-by: pi.dev
1e28416 to
bbf14cf
Compare
|
@jkhelil can you check again ? I have rebased and updated the PR PTAL 🙇 |
|
/lgtm |
Changes
Rename the Operator component API from
TektonSchedulertoTektonKueue,including
TektonConfig.spec.kueue, controller wiring, generated clients andCRDs, RBAC, Helm and OperatorHub manifests, tests, and documentation.
Retain the deprecated
TektonSchedulerCRD andTektonConfig.spec.schedulerfield during a compatibility window. Pre-upgrade reconciliation migrates
existing configuration and legacy resources to
TektonKueue; explicitlyconfigured
spec.kueuevalues take precedence. It also removes deprecatedInstallerSets and RBAC, waits for legacy resource deletion to complete, and
uses delayed requeues for expected migration steps instead of controller error
backoff.
The branch is rebased onto current
mainand generated CRD/Helm artifacts arerefreshed against Tekton Kueue v0.4.0. Repository and release-fetch references
use
tektoncd/tekton-kueue. Go imports retaingithub.com/konflux-ci/tekton-kueuebecause v0.4.0 still declares that modulepath.
Automated migration coverage includes disabled Scheduler configuration,
enabled configuration without a queue override, a changed queue name,
explicit
spec.kueueprecedence, InstallerSet/RBAC cleanup, and finalizerhandling.
A local Kind upgrade matrix from Operator v0.81.1 on Kubernetes v1.36.1
covered Scheduler disabled, Scheduler enabled with defaults, and Scheduler
enabled with
queueName: migration-test-queue. It verified that:TektonKueueoperand;pipelines-queue;migration-test-queuevalue was preserved;TektonKueueresources reached Ready;TektonConfigreturned to Ready.A raw-manifest upgrade on OpenShift 4.20.33 from Operator v0.81.1 with
queueName: migration-test-queueindependently verified the same migration,cleanup, queue preservation, and Ready states. All cluster operators remained
available and non-degraded.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes