Repository navigation
feat(namespacesync): add NamespaceSyncController for per-namespace resource management #3581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tekton-robot
merged 3 commits into
tektoncd:main
from
jkhelil:rfe-7814-namespace-sync-controller
Sep 11, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkhelil Any specific reason why we allow user's to make these choices for all these reconciliations? In legacy batch RBAC mode users/admins did not have the option to manually intervene this behavior. If we still consider manual intervention is required, could you consider addressing the following concerns:
A typo or malformed selector turns provisioning OFF everywhere. When the selector can't be parsed, namespaceMatchesSelector returns false (match nothing). So a small YAML mistake means every new namespace silently gets no pipeline SA, no SCC binding, no CA bundles — and pipelines there fail with permission errors. TektonConfig still shows Ready, so there's no hint anything is wrong.
namespaceSelector: {} means "match nothing" here, but in every other Kubernetes API an empty selector means "match everything." Someone will almost certainly write {} expecting "all namespaces" and get the exact opposite.
The current design hardens only one direction, "a typo can't accidentally widen sync to the whole cluster" but leaves the more likely mistake (accidentally turning everything off) both easy to hit and invisible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @anithapriyanatarajan
1.and 2 fixed
the reason for adding this is to avoid watching selected namespaces, eventually all, if the user dont want to opt in rbac provisioning through operator