fix(model): make certain OpenAI API compatible model fields correctly optional#3508
Open
imrehg wants to merge 2 commits into
Open
fix(model): make certain OpenAI API compatible model fields correctly optional#3508imrehg wants to merge 2 commits into
imrehg wants to merge 2 commits into
Conversation
|
|
github-actions
Bot
added
the
type: fix
… optional Some fields previously required by this code are not actually present in the "OpenAI Compatible" model listing responses of either LlamaCpp, or the LmStudio providers. Checking the actual OpenAI API specs, these fields are not required, and thus should be marked optional. Reviewed: https://developers.openai.com/api/reference/resources/models/methods/list and https://github.com/openai/openai-openapi/blob/5162af98d3147432c14680df789e8e12d4891e6b/openapi.yaml With these changes both of those providers' models could be listed (checked manually). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
imrehg
force-pushed
the
imrehg/openai-compatible-models
branch
from
3da9f35 to
5a5aa98
Compare
Author
|
Rebased on the current main, to keep up. Any feedback is welcome! NB: there are other issues to actually use the models (the templates handling), but this PR is a necessary first step to be able to load/list the models themselves. |
|
Action required: PR inactive for 5 days. |
github-actions
Bot
added
the
state: inactive
Author
|
Heyhey, anything I can do here, to move this change forward (or let me know if this is not desirable for you). I'm using this local patch to be able to run |
github-actions
Bot
removed
the
state: inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fields previously required by this code are not actually present in the "OpenAI Compatible" model listing responses of either LlamaCpp, or the LmStudio providers.
Checking the actual OpenAI API specs, these fields are not required, and thus should be marked optional.
Reviewed:
https://developers.openai.com/api/reference/resources/models/methods/list and
https://github.com/openai/openai-openapi/blob/5162af98d3147432c14680df789e8e12d4891e6b/openapi.yaml
With these changes both of those providers' models could be listed (checked manually).
Closes #3507