Repository navigation
Conversation
Pin the cleanup executable in the E2E package so frozen installs can run the existing cross-platform clean lifecycle without global tools.\n\nFixes t1protocol#255.
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Replace the added cleanup dependency with Bun's built-in filesystem API, removing lockfile churn and the Socket package alert while preserving cross-platform recursive cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rimrafexecutable with Bun's built-innode:fsrmSyncAPI.node_modulesandsrc/typechain.Motivation and Context
The E2E package exposes
bun run clean, but its script invoked an executable absent from both the package manifest and lockfile. A clean install therefore leftsrc/typechainintact and exited 127 withrimraf: command not foundunless the developer happened to have a global command.The package already requires Bun to run its scripts. Using Bun's built-in filesystem API makes the clean lifecycle self-contained and cross-platform without introducing another dependency.
Fixes #255.
An earlier revision declared
rimraf@5.0.1; the current revision removes that dependency and its lockfile changes, so the prior Socket package alert no longer applies to the final diff.How Has This Been Tested?
rimraf: command not foundand leftsrc/typechainpresent.bun install --frozen-lockfilesucceeded;bun run cleanexited 0 and removed bothnode_modulesandsrc/typechain;git diff --check— passed.canary.Types of changes (remove all unchecked types)
Checklist: