Repository navigation
Conversation
Run all requested load iterations while retaining and returning the first nonzero forge status so partial failures cannot be reported as success.\n\nFixes t1protocol#251.
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
forgestatus.forge.Motivation and Context
The wrapper previously exposed only the final loop command's status. An earlier failed broadcast followed by a successful final broadcast therefore made the whole load test exit 0.
The fix retains the wrapper's load-generator behavior by continuing all requested iterations, but it can no longer report success if any broadcast failed.
Fixes #251.
The separate zero-run validation issue is deliberately left out of this PR.
How Has This Been Tested?
bash script/test/7683/loadtesting/loadtest.failure-status.test.shafter the fix — passed:bash -non the production wrapper and regression script — passed.git diff --cached --check— passed.forge, placeholder environment values, and an isolated temporary directory; it performs no RPC or chain operation.Types of changes (remove all unchecked types)
Checklist: