Repository navigation
Conversation
Track active WebSocket authentication counts per normalized signer so closing one connection does not revoke other active sessions.\n\nFixes t1protocol#239.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
isLoggedIn(address)interface used by the server and price book.Motivation and Context
AuthServicepreviously stored authenticated solvers in aSet<string>. Two independently authenticated WebSockets using the same signer therefore shared one set entry, while each socket close calledlogout(address)and deleted that entry. Closing either socket deauthenticated the other active connection and prevented it from submitting prices.A per-address active-connection count keeps the signer authenticated while at least one successful connection remains. The failed-upgrade path remains balanced because it logs out the successful login that immediately preceded the failed upgrade.
Fixes #239.
How Has This Been Tested?
canarysource:Error: not authenticated.bun test test/AuthService.shared-login.test.ts— 2 passed, 0 failed.bun test test/Websocket.integration.test.ts -t 'Should reject parallel connections with the same nonce'— 1 passed, 0 failed.--ignoreConfig.Invalid argument type in ToBigInt operation, andprocessIntentLogs.test.tsasserts an asynchronous notification before it occurs.git diff --check— passed.Types of changes (remove all unchecked types)
Checklist: