Repository navigation
Conversation
Wait for pause and unpause transaction receipts before the monitor proceeds to another poll, preventing stale RPC state from triggering duplicate writes.\n\nFixes t1protocol#237.
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pauseOpenandunpauseOpentransaction receipts before returning from the client write methods.Motivation and Context
The intent pauser polls contract state sequentially. Previously,
T1ERC7683Client.pauseOpen()andunpauseOpen()returned as soon aswalletClient.writeContract()produced a broadcast hash. If the next poll read stale RPC state while that transaction was still pending, the monitor submitted the same state transition again.Waiting for the receipt keeps the current monitor iteration in flight until the transaction is confirmed or the Viem receipt wait fails. The next poll therefore cannot rebroadcast the same action while the prior transaction remains pending.
Fixes #237.
How Has This Been Tested?
waitForTransactionReceipt.bun test test/T1ERC7683Client.receipt.test.ts— 2 passed, 0 failed.bun test— 2 passed, 0 failed on this branch.bun x tsc --noEmit --target ESNext --module Preserve --moduleResolution Bundler --types bun --skipLibCheck --allowImportingTsExtensions src/T1ERC7683Client.ts test/T1ERC7683Client.receipt.test.tsbun test— 9 passed, 0 failed across four focused intent-pauser test files.git diff --check— passed.bun x tsc -p tsconfig.json --noEmitremains blocked on unchangedcanaryby the missing generated../../contracts/artifacts/src/T1ERC7683.sol/T1ERC7683.jsonartifact; the same error reproduces on the clean audited checkout.Types of changes (remove all unchecked types)
Checklist: