Repository navigation
Apply simplefs_writepage() only for kernels under 6.16 - #100
Merged
Merged
Conversation
aops->writepage has been removed and replaced with writepages since 6.16. The current codebase still builds with simplefs_writepage() on kernels higher than 6.15, which gives unused-function warning. Add in macros to ensure kernel module builds with simplefs_writepage() for kernels under 6.16.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
|
Thank @EricKim27 for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aops->writepage has been removed and replaced with writepages since 6.16. The current codebase still
builds with simplefs_writepage() on kernels higher than 6.15, which gives unused-function warning.
Add in macros to ensure kernel module builds with simplefs_writepage() for kernels under 6.16.
Summary by cubic
Fixes a build warning on kernels 6.16 and newer by compiling
simplefs_writepage()only for kernels under 6.16.Kernel 6.16 removed
aops->writepagein favor ofwritepages, so the function was previously built but unused, triggering an unused-function warning.Written for commit b01b717. Summary will update on new commits.