Repository navigation
Reconcile logic for JSON writing between {non-,}Embedded Swift. - #1950
Merged
Merged
Conversation
This PR adjusts the logic we use to write JSON to be as close as is reasonable between the Embedded and non-Embedded paths in our shared entry point function. I've factored out the logic for creating a JSON output stream to a new type, `JSON.Writer`. In non-Embedded Swift, it just opens a file handle and writes to that. In Embedded Swift, it handles the `_swift_testing_writeJSON()` abstraction. As part of this change, I've eliminated the concept of a "default" JSON destination in Embedded Swift. For implementations that really need or want a default destination, they can specify that some `path` string is the default (e.g. `"default"` or the empty string).
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
October 8, 2026 15:03
grynspan
added
tools integration
briancroom
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the logic we use to write JSON to be as close as is reasonable between the Embedded and non-Embedded paths in our shared entry point function.
I've factored out the logic for creating a JSON output stream to a new type,
JSON.Writer. In non-Embedded Swift, it just opens a file handle and writes to that. In Embedded Swift, it handles the_swift_testing_writeJSON()abstraction.As part of this change, I've eliminated the concept of a "default" JSON destination in Embedded Swift. For implementations that really need or want a default destination, they can specify that some
pathstring is the default (e.g."default"or the empty string).Checklist: