Repository navigation
Handle the presence of the "target triple" output line in TestCaseIterationTests. - #1947
Merged
grynspan merged 2 commits intoOct 7, 2026
Merged
Conversation
…rationTests. This test is sensitive to differences in output from Swift Testing. In particular, when we build with CMake, we emit an additional line of text indicating the target triple, which confuses some of the tests. This PR inserts the appropriate regex to match that line if the target triple was set at build time so that the tests pass.
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
October 6, 2026 23:29
jerryjrchen
approved these changes
Oct 6, 2026
stmontgomery
approved these changes
Oct 6, 2026
grynspan
deleted the
jgrynspan/maybe-have-triple-in-test-case-iteration-tests
branch
October 7, 2026 00:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is sensitive to differences in output from Swift Testing. In particular, when we build with CMake, we emit an additional line of text indicating the target triple, which confuses some of the tests.
This PR inserts the appropriate regex to match that line if the target triple was set at build time so that the tests pass.
Checklist: