Feat(SwiftRefactor): Implement InvertIfCondition refactoring - #3424
Open
amanmaurya92 wants to merge 1 commit into
Open
amanmaurya92 wants to merge 1 commit into
amanmaurya92 wants to merge 1 commit into
Conversation
Implement the InvertIfCondition refactoring action in SwiftRefactor which inverts a negated if condition and swaps the then and else branches. Co-authored-by: Rick Hohler <rick.hohler@gmail.com> Resolves swiftlang/sourcekit-lsp#2408
amanmaurya92
requested review from
hamishknight,
hborla and
rintaro
as code owners
September 3, 2026 11:33
Author
|
@rintaro @hborla @hamishknight can you please review this implementation and approve the workflows? |
Author
|
@ahoppen can you please approve the workflows? |
Member
|
Since #3263 was opened, we have decided that refactoring actions should generally be implemented in SourceKit-LSP. Could you open a PR in that repo? Thanks! |
Author
Yes, no problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
InvertIfConditionrefactoring action inSwiftRefactor, which supersedes stale PR #3263 and addresses maintainer review feedback for swiftlang/sourcekit-lsp#2408.Transformation: