build: restrict permissions for commitlint#195
Merged
Conversation
The pr-title workflow gives elevated pull-request write permissions to the third-party commitlint tool. This is a potential supply-chain vulnerability. This change restricts the permissions to only read for the commitlint tool. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
|
|
tokoko
approved these changes
Jun 17, 2026
tokoko
left a comment
tokoko
left a comment
Contributor
There was a problem hiding this comment.
tbh I'd rather we don't post the PR message at all 😆 but this is better than nothing
Member
Author
I am also not overly keen on the way comments are added and then removed. It would be nice if there was some other way to provide supporting information in the Details link when the PR check workflow fails. The DCO sign-off check app does this, but I don't know how. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pr-title workflow gives elevated pull-request write permissions to the third-party commitlint tool. This is a potential supply-chain vulnerability.
This change restricts the permissions to only read for the commitlint tool.