fix: handle unparameterized interval_day type#178
Open
thgschwind wants to merge 1 commit into
Open
Conversation
Allow interval_day to be used without an explicit precision parameter. Signed-off-by: Thomas Gschwind <thg@zurich.ibm.com>
nielspardon
reviewed
Jun 17, 2026
Comment on lines
+154
to
+159
| if parametrized_type.precision is None: | ||
| return Type( | ||
| interval_day=Type.IntervalDay( | ||
| nullability=nullability, | ||
| ) | ||
| ) |
Member
There was a problem hiding this comment.
Do you have a little bit more context on whether this is only an issue for IntervalDay for you and how this is triggered? I'm asking since we have very similar code above for PrecisionTimestampContext and PrecisionTimestampTZContext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow interval_day to be used without an explicit precision parameter.
Fixes: #177