fix(core): add compiled output to javadocImmutable classpath#953
Open
nielspardon wants to merge 1 commit into
Open
fix(core): add compiled output to javadocImmutable classpath#953nielspardon wants to merge 1 commit into
nielspardon wants to merge 1 commit into
Conversation
The javadocImmutable task only had compileClasspath (external dependency JARs) but not the project's own compiled output. Immutables-generated sources import their hand-written enclosing types (Hint, Rel, etc.) which live in the project's compiled classes, not in external JARs, causing 100+ 'cannot find symbol' / 'package does not exist' errors from javadoc. Add sourceSets["main"].output.classesDirs to the classpath so javadoc can resolve cross-references between generated and hand-written sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
javadocImmutabletask only hadcompileClasspath(external dependency JARs) but not the project's own compiled output. Immutables-generated sources import their hand-written enclosing types (Hint,Rel, etc.) which live in the project's compiled classes, not in external JARs, causing 100+cannot find symbol/package does not existerrors from javadoc.Add
sourceSets["main"].output.classesDirsto the classpath so javadoc can resolve cross-references between generated and hand-written sources.🤖 Generated with AI