feat(core)!: remove deprecated Time, Timestamp, TimestampTZ types and literals#950
Open
nielspardon wants to merge 1 commit into
Open
feat(core)!: remove deprecated Time, Timestamp, TimestampTZ types and literals#950nielspardon wants to merge 1 commit into
nielspardon wants to merge 1 commit into
Conversation
nielspardon
force-pushed
the
feat/remove-deprecated-time-types
branch
from
f401f4b to
1cda539
Compare
… literals Removes types, literals, and function mappings that were previously deprecated in substrait-java and are removed in Substrait v0.88.0: - Type.Time, Type.Timestamp, Type.TimestampTZ - Expression.TimeLiteral, Expression.TimestampLiteral, Expression.TimestampTZLiteral - TypeCreator.TIME, TIMESTAMP, TIMESTAMP_TZ - All visitor methods and proto converter cases for the above Also updates the substrait submodule to v0.88.0, which removes these types from the proto definitions and ANTLR grammar. Additional fixes required by v0.88.0: - ParseToPojo: handle new integer_parameter(x) function call in the type derivation grammar used by functions_datetime.yaml - ToTypeString: add missing visit(ParameterizedType.PrecisionTime) - EnumConverter: update extract function keys for precision_time (req_time -> req_pt) and remove stale req_ts/req_tstz_str entries - FunctionConversionTest: update test signatures to v0.88.0 function keys and add precision arg to strptime_time/strptime_timestamp BREAKING CHANGE: Type.Time, Type.Timestamp, Type.TimestampTZ and their corresponding expression literals and visitor methods are removed; use the precision variants (Type.PrecisionTime, Type.PrecisionTimestamp, Type.PrecisionTimestampTZ) instead. Part of substrait-io#800 Closes substrait-io#804
nielspardon
force-pushed
the
feat/remove-deprecated-time-types
branch
from
1cda539 to
1b14618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes types, literals, and function mappings that were previously deprecated in substrait-java and are removed in Substrait v0.88.0.
Part of #800 — closes #804.
Changes
Removed deprecated types and literals:
Type.Time,Type.Timestamp,Type.TimestampTZExpression.TimeLiteral,Expression.TimestampLiteral,Expression.TimestampTZLiteralTypeCreator.TIME,TIMESTAMP,TIMESTAMP_TZSubstrait submodule updated to v0.88.0, which removes these types from the proto definitions and ANTLR grammar.
Additional fixes required by v0.88.0:
ParseToPojo: handle newinteger_parameter(x)function call in the type derivation grammar used byfunctions_datetime.yamlToTypeString: add missingvisit(ParameterizedType.PrecisionTime)returning"pt"EnumConverter: update extract function keys forprecision_time(req_time→req_pt) and remove stalereq_ts/req_tstz_strentriesFunctionConversionTest: update test signatures to v0.88.0 function keys and add precision arg tostrptime_time/strptime_timestampBreaking Change
Type.Time,Type.Timestamp,Type.TimestampTZand their corresponding expression literals and visitor methods are removed; use the precision variants (Type.PrecisionTime,Type.PrecisionTimestamp,Type.PrecisionTimestampTZ) instead.🤖 Generated with AI