Disabled reportUnnecessaryTypeIgnoreComment in pyproject.toml - #1912
Merged
jar-stripe merged 1 commit intoSep 16, 2026
Merged
Conversation
xavdid
approved these changes
Sep 16, 2026
jar-stripe
deleted the
jar/disable-report-unnecessary-type-ignore-comment
branch
September 16, 2026 22:24
zacchua-stripe
added a commit
that referenced
this pull request
Sep 18, 2026
* rename changefiles that don't adhere to new naming rules * Support `EventNotification`s with singleton related objects (#1904) * support related singleton objects * add missing changefile * disabled reportUnnecessaryTypeIgnoreComment (#1912) * Add option to suppress Stripe notices (#1909) * Add option to suppress Stripe notices Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for notice suppression Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Clarify Stripe notice suppression instructions Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Fix event handler account scoping (#1911) * Fix event handler account scoping Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add PR URL to changefile Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Remove deprecated StripeObject.request method Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for StripeObject.request removal Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Remove changelog section metadata Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: David Brownman <xavdid@stripe.com> Co-authored-by: David Brownman <1231935+xavdid@users.noreply.github.com> Co-authored-by: jar-stripe <jar@stripe.com> Co-authored-by: codex <noreply@openai.com>
jar-stripe
added a commit
that referenced
this pull request
Sep 29, 2026
* rename changefiles that don't adhere to new naming rules * Support `EventNotification`s with singleton related objects (#1904) * support related singleton objects * add missing changefile * disabled reportUnnecessaryTypeIgnoreComment (#1912) * Add option to suppress Stripe notices (#1909) * Add option to suppress Stripe notices Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for notice suppression Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Clarify Stripe notice suppression instructions Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Fix event handler account scoping (#1911) * Fix event handler account scoping Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add PR URL to changefile Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Remove deprecated StripeObject.request method Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for StripeObject.request removal Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Remove changelog section metadata Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: David Brownman <xavdid@stripe.com> Co-authored-by: David Brownman <1231935+xavdid@users.noreply.github.com> Co-authored-by: jar-stripe <jar@stripe.com> Co-authored-by: codex <noreply@openai.com>
jar-stripe
added a commit
that referenced
this pull request
Sep 30, 2026
* seed the migration guide for the next major version * Remove deprecated StripeObject.request method (#1914) * rename changefiles that don't adhere to new naming rules * Support `EventNotification`s with singleton related objects (#1904) * support related singleton objects * add missing changefile * disabled reportUnnecessaryTypeIgnoreComment (#1912) * Add option to suppress Stripe notices (#1909) * Add option to suppress Stripe notices Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for notice suppression Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Clarify Stripe notice suppression instructions Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Fix event handler account scoping (#1911) * Fix event handler account scoping Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add PR URL to changefile Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Remove deprecated StripeObject.request method Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for StripeObject.request removal Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Remove changelog section metadata Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: David Brownman <xavdid@stripe.com> Co-authored-by: David Brownman <1231935+xavdid@users.noreply.github.com> Co-authored-by: jar-stripe <jar@stripe.com> Co-authored-by: codex <noreply@openai.com> * DEVSDK-3212: Apply positional-only service path parameters, and update CHANGELOG with changes (#1920) * Rename Reversal to TransferReversal (#1915) * Rename Reversal to TransferReversal Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Document TransferReversal migration Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Update migration guide --------- Co-authored-by: codex <noreply@openai.com> Co-authored-by: jar-stripe <jar@stripe.com> * Make remaining overloaded method args positional only and remove unecessary suppression comments (#1924) * Make remaining overloaded method args positional only and remove unecessary suppression comments * DEVSDK-3290: Improve changefile and migration guide associated with enforcing positional-only leading params on overloaded methods * Revise migration guide for SDK v16 API changes Updated the migration guide for SDK v16 to reflect the new API version and included links to the API release process and changelog. * Pin stripe-mock to the SDK OpenAPI version (#1927) --------- Co-authored-by: David Brownman <xavdid@stripe.com> Co-authored-by: zacchua-stripe <zacchua@stripe.com> Co-authored-by: David Brownman <1231935+xavdid@users.noreply.github.com> Co-authored-by: jar-stripe <jar@stripe.com> Co-authored-by: codex <noreply@openai.com> Co-authored-by: mark-kogan-stripe <markisaackogan@stripe.com> Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
jar-stripe
added a commit
that referenced
this pull request
Sep 30, 2026
* seed the migration guide for the next major version * Remove deprecated StripeObject.request method (#1914) * rename changefiles that don't adhere to new naming rules * Support `EventNotification`s with singleton related objects (#1904) * support related singleton objects * add missing changefile * disabled reportUnnecessaryTypeIgnoreComment (#1912) * Add option to suppress Stripe notices (#1909) * Add option to suppress Stripe notices Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for notice suppression Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Clarify Stripe notice suppression instructions Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Fix event handler account scoping (#1911) * Fix event handler account scoping Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add PR URL to changefile Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Remove deprecated StripeObject.request method Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for StripeObject.request removal Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Remove changelog section metadata Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: David Brownman <xavdid@stripe.com> Co-authored-by: David Brownman <1231935+xavdid@users.noreply.github.com> Co-authored-by: jar-stripe <jar@stripe.com> Co-authored-by: codex <noreply@openai.com> * DEVSDK-3212: Apply positional-only service path parameters, and update CHANGELOG with changes (#1920) * Rename Reversal to TransferReversal (#1915) * Rename Reversal to TransferReversal Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Document TransferReversal migration Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Update migration guide --------- Co-authored-by: codex <noreply@openai.com> Co-authored-by: jar-stripe <jar@stripe.com> * Make remaining overloaded method args positional only and remove unecessary suppression comments (#1924) * Make remaining overloaded method args positional only and remove unecessary suppression comments * DEVSDK-3290: Improve changefile and migration guide associated with enforcing positional-only leading params on overloaded methods * Revise migration guide for SDK v16 API changes Updated the migration guide for SDK v16 to reflect the new API version and included links to the API release process and changelog. * Pin stripe-mock to the SDK OpenAPI version (#1927) --------- Co-authored-by: David Brownman <xavdid@stripe.com> Co-authored-by: zacchua-stripe <zacchua@stripe.com> Co-authored-by: David Brownman <1231935+xavdid@users.noreply.github.com> Co-authored-by: jar-stripe <jar@stripe.com> Co-authored-by: codex <noreply@openai.com> Co-authored-by: mark-kogan-stripe <markisaackogan@stripe.com> Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
reportUnnecessaryTypeIgnoreComment reports an error for unnecessary
pyright: ignorecomments. A recent change to clearly separate positional and named arguments made many of our existing type ignore comments unnecessary. This disables the report for now. Long term, we will fix this upstream in codegen.What?
reportUnnecessaryTypeIgnoreComment= false inpyproject.tomlSee Also
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.