Fix event handler account scoping - #1911
Merged
zacchua-stripe merged 4 commits intoSep 17, 2026
Merged
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
zacchua-stripe
marked this pull request as ready for review
September 16, 2026 19:39
zacchua-stripe
requested review from
kidus-stripe
and removed request for
a team
September 16, 2026 19:39
xavdid
approved these changes
Sep 16, 2026
zacchua-stripe
enabled auto-merge (squash)
September 17, 2026 00:13
zacchua-stripe
deleted the
zacchua/fix-event-handler-account-context
branch
September 17, 2026 18:30
zacchua-stripe
added a commit
that referenced
this pull request
Sep 18, 2026
* rename changefiles that don't adhere to new naming rules * Support `EventNotification`s with singleton related objects (#1904) * support related singleton objects * add missing changefile * disabled reportUnnecessaryTypeIgnoreComment (#1912) * Add option to suppress Stripe notices (#1909) * Add option to suppress Stripe notices Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for notice suppression Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Clarify Stripe notice suppression instructions Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Fix event handler account scoping (#1911) * Fix event handler account scoping Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add PR URL to changefile Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Remove deprecated StripeObject.request method Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for StripeObject.request removal Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Remove changelog section metadata Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: David Brownman <xavdid@stripe.com> Co-authored-by: David Brownman <1231935+xavdid@users.noreply.github.com> Co-authored-by: jar-stripe <jar@stripe.com> Co-authored-by: codex <noreply@openai.com>
jar-stripe
added a commit
that referenced
this pull request
Sep 23, 2026
* Add option to suppress Stripe notices (#1909) * Add option to suppress Stripe notices Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for notice suppression Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Clarify Stripe notice suppression instructions Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Fix event handler account scoping (#1911) * Fix event handler account scoping Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add PR URL to changefile Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Document Stripe notice suppression (#1923) Committed-By-Agent: goose Orbit-Session-Id: d60d503e-7c8a-4aa0-89d1-37cc435afc02 --------- Co-authored-by: zacchua-stripe <zacchua@stripe.com> Co-authored-by: codex <noreply@openai.com> Co-authored-by: jar-stripe <jar@stripe.com> Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
jar-stripe
added a commit
that referenced
this pull request
Sep 29, 2026
* rename changefiles that don't adhere to new naming rules * Support `EventNotification`s with singleton related objects (#1904) * support related singleton objects * add missing changefile * disabled reportUnnecessaryTypeIgnoreComment (#1912) * Add option to suppress Stripe notices (#1909) * Add option to suppress Stripe notices Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for notice suppression Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Clarify Stripe notice suppression instructions Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Fix event handler account scoping (#1911) * Fix event handler account scoping Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add PR URL to changefile Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Remove deprecated StripeObject.request method Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for StripeObject.request removal Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Remove changelog section metadata Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: David Brownman <xavdid@stripe.com> Co-authored-by: David Brownman <1231935+xavdid@users.noreply.github.com> Co-authored-by: jar-stripe <jar@stripe.com> Co-authored-by: codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Follow up to stripe/stripe-node#2850 (comment). Event notification callback clients inherited the original client’s
Stripe-Accountconfiguration while also applying the event’sStripe-Context, which is an error. Hence we drop stripe-accountWhat?
See Also
http://go/j/RUN_DEVSDK-3063
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.