feat: add support for Simplicity version checking in taproot environment#1
Open
stringhandler wants to merge 1 commit into
Open
feat: add support for Simplicity version checking in taproot environment#1stringhandler wants to merge 1 commit into
stringhandler wants to merge 1 commit into
Conversation
Adds a check for jets that have been added after a deployed version of simplicity. This check can be added to new jets using a minimum version. If the version is lower, the jet will automatically fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: built on BlockstreamResearch#339
I opened a separate PR so that changes related to the versioning can be discussed separately.
Here is a possible, simple solution to versioning. Added a check for the tapleaf version. If it is not
0xc2(version to be decided), the jet will fail. This is should be similar in practice to failing when the jet is not found.I created a function to map tapleaf versions to a monotonically increasing version so that a
min_versioncan be specified to make adding future jets easier.