Test quality improvements#2
Draft
streaky wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive integration test harness for the ACME API, enabling end-to-end testing against a real Pebble ACME server. It also includes several improvements to configuration, documentation, and testing practices.
Integration test harness and related infrastructure:
docker-compose.harness.yaml) to spin up a Pebble ACME server, challenge server, and test instance of the API for end-to-end testing.tests/integration/pebble_harness/run_harness.py) to orchestrate the harness lifecycle: setup, health check, test execution, and teardown.acme.api.test-config.yamlfor the API andpebble-config.jsonfor Pebble, to support isolated integration tests. [1] [2]Testing and Makefile enhancements:
test-harnesstarget to theMakefileto automate running the integration harness, and updated.PHONYtargets accordingly. [1] [2]Configuration and documentation improvements:
check_interval_hoursinRenewalConfigto afloatand allowed values greater than zero for more flexible renewal scheduling.README.mdto emphasize that the service is experimental and should only be used with strict access controls.