Skip to content

chore: address JavaScript lint error#12074

Merged
kgryte merged 1 commit intostdlib-js:developfrom
Aj242005:fix/issue-11983
May 10, 2026
Merged

chore: address JavaScript lint error#12074
kgryte merged 1 commit intostdlib-js:developfrom
Aj242005:fix/issue-11983

Conversation

@Aj242005
Copy link
Copy Markdown
Contributor

@Aj242005 Aj242005 commented May 10, 2026

Resolves #11983

Description

What is the purpose of this pull request?
This pull request:

the javascript lint workflow was flagging an error in lib/node_modules/@stdlib/math/base/special/floorn/test/test.native.js at 118th line ,previously the comment was // => -0.30000000000000004 ,and now i changed it to // returns -0.30000000000000004 based on the linter's suggestion within the issue's description

Related Issues

Does this pull request have any related issues?
This pull request has the following related issues:
#11983

Questions

Any questions for reviewers of this pull request?
No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

the linting workflow was flagging '// => <number>' so, converted it into '// returns <number>'

Signed-off-by: Akshit Jain <akshitjain6661@gmail.com>
@Aj242005 Aj242005 requested a review from a team May 10, 2026 19:16
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels May 10, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label May 10, 2026
@kgryte kgryte changed the title fix : javaScript lint errors - 11983 chore: address JavaScript lint error May 10, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels May 10, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte kgryte merged commit 245721a into stdlib-js:develop May 10, 2026
125 of 127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants