chore: follow-up corrections for commits merged to develop on 2026-05-10#12052
Merged
chore: follow-up corrections for commits merged to develop on 2026-05-10#12052
Conversation
…eUniform` namespace entries
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
May 10, 2026
kgryte
reviewed
May 10, 2026
Restores `random.discreteUniform`'s `@stdlib/random/uniform` cross-reference and drops the redundant self-references from all sibling `random.*` entries per review.
kgryte
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-05-09 18:57 PDT (d1d485d) and 2026-05-10 04:42 PDT (e64ea31).Description
This pull request:
developin the past 24 hours. All findings were independently flagged by at least one of four parallel review agents and re-verified against the current source before fixing.ndarray/base/descriptorndarray/base/descriptorREADME's Notes block listed the returned property as**buffer**while the implementation returnsdata(b5d65f3); corrected to**data**inlib/node_modules/@stdlib/ndarray/base/descriptor/README.mdto matchlib/main.js,repl.txt, and theDescriptorinterface.namespace/lib/namespace/randomlib/node_modules/@stdlib/namespace/lib/namespace/random/main.jshad copy-paste errors in therelatedarrays:discreteUniformincorrectly referenced@stdlib/random/uniforminstead of@stdlib/random/discrete-uniform(line 154), anduniformincorrectly referenced the discrete-uniform strided variant instead of the uniform one (line 443). Both were corrected to match the canonical namespace convention.ndarray/base/from-scalar// returnsannotation instead of// buf =>for Complex128 and Complex64 doctest examples inlib/node_modules/@stdlib/ndarray/base/from-scalar/docs/types/index.d.ts(lines 109 and 144).ndarray/from-scalarlib/node_modules/@stdlib/ndarray/from-scalar/docs/types/index.d.ts(lines 247 and 279) to use// returnsinstead of// buf =>for consistency with sibling doctests.Related Issues
None.
Questions
No.
Other
Validation
Each fix is the merged + de-duplicated output of four parallel review agents (two style auditors against
docs/style-guides/javascript, two bug scanners restricted to the diff window).Checked:
math/base/special/cabsf,stats/base/ndarray/sum,blas/ext/base/ndarray/gjoin).ndarray/base/descriptorpackage.random.*namespacerelatedarrays against the canonical pattern within the same file.Deliberately excluded (anything requiring interpretation or out-of-window context):
chore: modernize examples and benchmarkssweep acrossstats/base/ndarray/*, the TypeScript generic removals, theFloat16Array/*Vector/random.*namespace additions themselves, and theComplex64import fixes — all reviewed clean.covarmtk/dcovarmtk/scovarmtkdocs (mixed-article bullet lists in thearraysparameter description) — single-agent finding; intent of the originatingdocs: update copycommits was ambiguous, so dropped.random.*relatedarray — the pattern is internally consistent across all 32 newly added entries; treated as deliberate until clarified.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code. The fixes were surfaced by four parallel review agents reviewing the past 24 hours of
developcommits, then merged, de-duplicated, and re-verified against the source before any edits were applied. Each fix was constrained to the originating commit's diff window; nothing outside the window was touched.Generated by Claude Code